[all-commits] [llvm/llvm-project] aea6a1: [test][NFC] Add more keys to test SDKSettings file...

[Ian Anderson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aea6a19d7869e8f261aab6f85e7d0257b4983e2e
      https://github.com/llvm/llvm-project/commit/aea6a19d7869e8f261aab6f85e7d0257b4983e2e
  Author: Ian Anderson <iana at apple.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    R clang/test/Driver/Inputs/DriverKit19.0.sdk/SDKSettings.plist
    A clang/test/Driver/Inputs/DriverKit19.0.sdk/SDKSettings.txt
    M clang/test/Driver/Inputs/DriverKit21.0.1.sdk/SDKSettings.json
    M clang/test/Driver/Inputs/DriverKit23.0.sdk/SDKSettings.json
    R clang/test/Driver/Inputs/MacOSX10.14.sdk/SDKSettings.json
    A clang/test/Driver/Inputs/MacOSX10.15.sdk/SDKSettings.json
    R clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk/SDKSettings.json
    M clang/test/Driver/Inputs/MacOSX15.0.sdk/SDKSettings.json
    M clang/test/Driver/Inputs/MacOSX15.1.sdk/SDKSettings.json
    M clang/test/Driver/Inputs/WatchOS6.0.sdk/SDKSettings.json
    M clang/test/Driver/Inputs/iPhoneOS13.0.sdk/SDKSettings.json
    M clang/test/Driver/clang-cc1as-target-variant.s
    M clang/test/Driver/darwin-builtin-modules.c
    M clang/test/Driver/darwin-invalid-version-range.c
    M clang/test/Driver/darwin-ld-platform-version-driverkit.c
    M clang/test/Driver/darwin-ld-platform-version-maccatalyst.c
    M clang/test/Driver/darwin-ld-platform-version-macos.c
    M clang/test/Driver/darwin-ld-platform-version-target-version.c
    M clang/test/Driver/darwin-objc-runtime-maccatalyst-target-variant.m
    M clang/test/Driver/darwin-objc-runtime-maccatalyst.m
    M clang/test/Driver/darwin-sdk-version-maccatalyst.c
    M clang/test/Driver/darwin-sdk-version.c
    M clang/test/Driver/darwin-target-variant-sdk-version.c
    M clang/test/Driver/modulemap-allow-subdirectory-search.c
    M clang/test/InstallAPI/Inputs/MacOSX13.0.sdk/SDKSettings.json
    M clang/test/Modules/sdk-settings-json-dep.m
    M clang/test/Sema/Inputs/AppleTVOS15.0.sdk/SDKSettings.json
    M clang/test/Sema/Inputs/MacOSX11.0.sdk/SDKSettings.json
    R clang/test/Sema/Inputs/WatchOS7.0.sdk/SDKSettings.json
    A clang/test/Sema/Inputs/WatchOS8.0.sdk/SDKSettings.json
    R clang/test/Sema/Inputs/XROS.sdk/SDKSettings.json
    A clang/test/Sema/Inputs/XROS26.0.sdk/SDKSettings.json
    M clang/test/Sema/attr-availability-ios-fallback-aligned-versions.c
    M clang/test/Sema/attr-availability-iosmac-infer-from-macos.c
    M clang/test/Sema/attr-availability-watchos.c

  Log Message:
  -----------
  [test][NFC] Add more keys to test SDKSettings files (#177538)

Every time DarwinSDKInfo reads a new key out of SDKSettings, a boatload
of test SDKSettings files need to be updated across several repositories
and forks and branches. It’s tedious to be careful to update those with
real values so that the tests are properly regression testing older
SDKs. It’s important to be careful so that the tests are accurate, e.g.
to prevent the scenario where DarwinSDKInfo starts reading a new key out
of SDKSettings and assumes that it’s always available everywhere, when
in reality it was only added a few releases ago and will break with
older SDKs. If the test SDKSettings files continue to be updated ad hoc,
it’s going to be really easy to copy/paste a default value everywhere,
and then clients will see incorrect behaviors with the real SDKs, or
even compiler crashes if the key is unconditionally read. Preemptively
add all of the maybe-possibly-compiler relevant keys to the test
SDKSettings files from the real SDKs so that the test files are an
accurate representation and shouldn't need to be touched in the future.
Where the test SDKSettings have intentionally doctored data, add a
Comments key explaining what is changed from the real SDK, and alter the
SDK name with a tag indicating the change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications