[all-commits] [llvm/llvm-project] 7f8557: [mlir] Always update ExtractValue to use last cont...

[neildhar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f8557cb2ef3065394d844cfd2c3592fcbaf4b90
      https://github.com/llvm/llvm-project/commit/7f8557cb2ef3065394d844cfd2c3592fcbaf4b90
  Author: neildhar <neildhar at users.noreply.github.com>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Dialect/LLVMIR/canonicalize.mlir

  Log Message:
  -----------
  [mlir] Always update ExtractValue to use last container in insert chain (#176588)

The current logic only updates the container operand to the last
`InsertValueOp` in a chain if we haven't switched to a nested insert
chain. Instead, keep track of the new container value and extract
position at all times, and always update if we have found a point higher
up in the chain to extract from.

This allows us to bypass more insertions (see the updated test) when we
are accessing nested struct members. It also allows us to move the
constant check back to the top, because we can just do it on a
successive call to fold.

Also added a test for a missing case (it is unchanged by this PR).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications