[all-commits] [llvm/llvm-project] b76c84: [flang][OpenMP] Fix crash when arrays used in LINE...

Krish Gupta via All-commits all-commits at lists.llvm.org
Mon Jan 12 12:26:16 PST 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b76c84e70f4fb420b26b3887d9270fdb90d41933
      https://github.com/llvm/llvm-project/commit/b76c84e70f4fb420b26b3887d9270fdb90d41933
  Author: Krish Gupta <krishom70 at gmail.com>
  Date:   2026-01-12 (Mon, 12 Jan 2026)

  Changed paths:
    M flang/lib/Semantics/check-omp-loop.cpp
    M flang/test/Semantics/OpenMP/cray-pointer-usage.f90
    M flang/test/Semantics/OpenMP/linear-clause01.f90
    M flang/test/Semantics/OpenMP/linear-iter.f90
    A flang/test/Semantics/OpenMP/simd-linear-array.f90

  Log Message:
  -----------
  [flang][OpenMP] Fix crash when arrays used in LINEAR clause (#175383)

Closes #171007

Found this crash while testing OpenMP code - turns out putting an array
in a LINEAR clause on SIMD directives causes the compiler to blow up
with "unknown LLVM dialect type" and hit an UNREACHABLE.

The issue is that LINEAR clauses only accept scalar variables (rank 0),
but we weren't checking for that early enough. The invalid array type
would slip through semantic analysis and then crash during MLIR to LLVM
IR translation when it tried to convert the type.

**What changed:**
- Added a rank check in the LINEAR clause validation to catch arrays up
front
- Made an exception for `declare simd` with the REF modifier since
that's actually allowed per spec
- Added tests covering different array types (1D, multi-dim,
assumed-shape)
- Updated existing tests that now catch the new error

Tested with the original reproducer and it now fails cleanly with a
proper error message instead of crashing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list