[all-commits] [llvm/llvm-project] cc7217: [LLDB][PDB] Access object file through module (#16...

[nerix via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc72171322a982b3d39a2688c45372ee7b5f8b67
      https://github.com/llvm/llvm-project/commit/cc72171322a982b3d39a2688c45372ee7b5f8b67
  Author: nerix <nerixdev at outlook.de>
  Date:   2025-11-28 (Fri, 28 Nov 2025)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    M lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
    A lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp

  Log Message:
  -----------
  [LLDB][PDB] Access object file through module (#169728)

When a PDB is loaded through `target symbols add <pdb-path>`, its
`m_objectfile_sp` is an `ObjectFilePDB` instead of `ObjectFilePECOFF`
(the debugged module). In both the native and DIA plugin, some paths
assumed that `m_objectfile_sp` is the debugged module. With this PR,
they go through `m_objfile_sp->GetModule()->GetObjectFile()`.

For the DIA plugin, this lead to an assertion failure
(https://github.com/llvm/llvm-project/issues/169628#issuecomment-3582555277)
and for both plugins, it meant that the symbol table wasn't loaded.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications