[all-commits] [llvm/llvm-project] 9c414c: [clangd] Make lit tests work with the internal shell

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c414c428d8464c829d551d0d91029339e746842
      https://github.com/llvm/llvm-project/commit/9c414c428d8464c829d551d0d91029339e746842
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-11-25 (Tue, 25 Nov 2025)

  Changed paths:
    M clang-tools-extra/clangd/test/CMakeLists.txt
    M clang-tools-extra/clangd/test/include-cleaner-batch-fix.test
    M clang-tools-extra/clangd/test/index-tools.test
    M clang-tools-extra/clangd/test/system-include-extractor.test

  Log Message:
  -----------
  [clangd] Make lit tests work with the internal shell

This makes all of the clangd tests work with the internal shell.
Modifications needed for each test are as follows:
1. system-include-extractor.test was using variable expansion which is
   not supported in the internal shell. This patch rewrites it to use
   the readfile mechanism along with python. This isn't super pretty but
   is readily understandable and there are only two tests across the
   monorepo that use this construction, so making it prettier is hard to
   justify.
2. include-cleaner-batch-fix.test - Was using $'' construction to create
   new lines in a string. Simply replace it with multiple echo commands
   to be canonical with the rest of the repository.
3. index-tools.test - Just add IndexBenchmark to the clangd test
   depends, so the test now just works unconditionally. This should
   significantly increase test coverage at little cost.

Reviewers: ilovepi, HighCommander4, petrhosek, kadircet

Reviewed By: ilovepi

Pull Request: https://github.com/llvm/llvm-project/pull/169539



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications