[all-commits] [llvm/llvm-project] f6d26f: [HIP] Perform implicit pointer cast when compiling...

[Juan Manuel Martinez Caamaño via All-commits]

  Branch: refs/heads/users/jmmartinez/fix/load_lds_typesignature/1
  Home:   https://github.com/llvm/llvm-project
  Commit: f6d26ff64b2030d8c091b30fb15647cf7227c389
      https://github.com/llvm/llvm-project/commit/f6d26ff64b2030d8c091b30fb15647cf7227c389
  Author: Juan Manuel Martinez Caamaño <jmartinezcaamao at gmail.com>
  Date:   2025-11-25 (Tue, 25 Nov 2025)

  Changed paths:
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/SemaHIP/amdgpu-gfx950-load-to-lds.hip

  Log Message:
  -----------
  [HIP] Perform implicit pointer cast when compiling device code, not when -fcuda-is-device

When compiling HIP device code, we add implicit casts for the pointer
arguments being passed to builtin calls.

When compiling for the host, apply the same casts for __device__ or __kernel__ functions,
since the device side of the source should still pass type checks.

This patch changes the condition depending on -fcuda-is-device to depend
on if the builtin's caller is marked as __device__ or __kernel__.

stack-info: PR: https://github.com/llvm/llvm-project/pull/165387, branch: users/jmmartinez/fix/load_lds_typesignature/1


  Commit: c598f1b66e903d587977e2fa05259ce42c66123e
      https://github.com/llvm/llvm-project/commit/c598f1b66e903d587977e2fa05259ce42c66123e
  Author: Juan Manuel Martinez Caamaño <jmartinezcaamao at gmail.com>
  Date:   2025-11-25 (Tue, 25 Nov 2025)

  Changed paths:
    M clang/lib/Sema/SemaExpr.cpp

  Log Message:
  -----------
  [Review] Drop the caller is device condition


  Commit: cf96a53a63f974684aee73697f47ef8a5fff8945
      https://github.com/llvm/llvm-project/commit/cf96a53a63f974684aee73697f47ef8a5fff8945
  Author: Juan Manuel Martinez Caamaño <jmartinezcaamao at gmail.com>
  Date:   2025-11-25 (Tue, 25 Nov 2025)

  Changed paths:
    M clang/lib/Sema/SemaExpr.cpp

  Log Message:
  -----------
  [Review] Format comment


Compare: https://github.com/llvm/llvm-project/compare/011550bafcb5...cf96a53a63f9

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications