[all-commits] [llvm/llvm-project] 499664: Revert "[ASTMatchers] Make isExpandedFromMacro acc...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4996645594cf9e2e318c0e693d9ec30d0aac5762
      https://github.com/llvm/llvm-project/commit/4996645594cf9e2e318c0e693d9ec30d0aac5762
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-11-23 (Sun, 23 Nov 2025)

  Changed paths:
    M clang-tools-extra/clang-tidy/objc/AssertEqualsCheck.cpp
    M clang/docs/LibASTMatchersReference.html
    M clang/include/clang/ASTMatchers/ASTMatchers.h
    M clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp

  Log Message:
  -----------
  Revert "[ASTMatchers] Make isExpandedFromMacro accept llvm::StringRef… (#167060)" (#169238)

This reverts commit a52e1af7f766e26a78d10d31da98af041dd66410.

That commit reverted a change (making isExpandedFromMacro take a
std::string) that was explicitly added to avoid lifetime issues. We ran
into issues with some internal matchers due to this, and it probably is
not an uncommon downstream use case. This patch restroes the original
functionality and adds a test to ensure that the functionality is
preserved.

https://reviews.llvm.org/D90303 contains more discussion.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications