[all-commits] [llvm/llvm-project] 4b9d7e: Reapply "[libc] Return errno from OFD failure path...

Jackson Stogel via All-commits all-commits at lists.llvm.org
Mon Nov 10 13:39:56 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b9d7e167b2ab6b7cc6d23516fad8c39ea9bc55f
      https://github.com/llvm/llvm-project/commit/4b9d7e167b2ab6b7cc6d23516fad8c39ea9bc55f
  Author: Jackson Stogel <jtstogel at gmail.com>
  Date:   2025-11-10 (Mon, 10 Nov 2025)

  Changed paths:
    M libc/src/__support/OSUtil/linux/fcntl.cpp
    M libc/test/src/fcntl/fcntl_test.cpp

  Log Message:
  -----------
  Reapply "[libc] Return errno from OFD failure paths in fcntl." (#166658) (#166846)

The previous implementation in #166252 (rolled back in #166658) caused
buildbot failures due to a bug in an added test. The modified
`UseAfterClose` did not pass a `struct flock` value to `fcntl`:


https://github.com/llvm/llvm-project/blob/2d5170594147b42a37698760d6e0194eec4f1390/libc/test/src/fcntl/fcntl_test.cpp#L175

Which ASAN caught and errored in the `fcntl` implementation when the
unspecified argument was accessed:


https://github.com/llvm/llvm-project/blob/c12cb2892c808af459eaa270b8738a2b375ecc9b/libc/src/__support/OSUtil/linux/fcntl.cpp#L59



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list