[all-commits] [llvm/llvm-project] f22d58: [mlir] Dialect Conversion: Fix expensive pattern c...

Tim Noack via All-commits all-commits at lists.llvm.org
Mon Nov 10 04:45:54 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f22d5884b2847c575b83b067c1c6b69f224f0854
      https://github.com/llvm/llvm-project/commit/f22d5884b2847c575b83b067c1c6b69f224f0854
  Author: Tim Noack <tim at noack.id>
  Date:   2025-11-10 (Mon, 10 Nov 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir] Dialect Conversion: Fix expensive pattern check in no-rollback mode (#166576)

Fixes a bug causing every conversion to fail fatally with "expected
pattern to replace the root operation or modify it in place" when
`MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS` is enabled and pattern
rollback is disabled.

When `allowPatternRollback` is disabled, the rewriter does not keep
track of the rewrites it performs and can therefore not use that list to
check whether the root op was replaced or updated in place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list