[all-commits] [llvm/llvm-project] 3a8894: [libc++][numeric] Marked saturation artithmetic fu...

[Hristo Hristov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a8894d7aff1fa4bd2502827c31dad87b5765f4d
      https://github.com/llvm/llvm-project/commit/3a8894d7aff1fa4bd2502827c31dad87b5765f4d
  Author: Hristo Hristov <hghristov.rmm at gmail.com>
  Date:   2025-11-09 (Sun, 09 Nov 2025)

  Changed paths:
    M libcxx/include/__numeric/saturation_arithmetic.h
    A libcxx/test/libcxx/numerics/nodiscard.verify.cpp
    R libcxx/test/std/numerics/bit/bitops.rot/nodiscard.verify.cpp

  Log Message:
  -----------
  [libc++][numeric] Marked saturation artithmetic functions as `[[nodiscard]]` (#166898)

...according to Coding Guidelines: *`[[nodiscard]]` should be applied to
functions where discarding the return value is most likely a correctness
issue.*

# References
-
https://libcxx.llvm.org/CodingGuidelines.html#apply-nodiscard-where-relevant
-
https://github.com/llvm/llvm-project/pull/166524#issuecomment-3495567876

Co-authored-by: Hristo Hristov <zingam at outlook.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications