[all-commits] [llvm/llvm-project] 883df7: [HLSL] Add internal linkage attribute to resources

[Helena Kotas via All-commits]

  Branch: refs/heads/users/hekota/pr166844-res-internal
  Home:   https://github.com/llvm/llvm-project
  Commit: 883df7bce01ddaedd133813b7e79397b974e6835
      https://github.com/llvm/llvm-project/commit/883df7bce01ddaedd133813b7e79397b974e6835
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/AST/HLSL/cbuffer.hlsl
    M clang/test/AST/HLSL/private.hlsl

  Log Message:
  -----------
  [HLSL] Add internal linkage attribute to resources

HLSL resources should not be externally visible from the module.
We made sure of this by marking them `static` as soon as they were declared.
However, this prevents us fixing issue #166458 because there is no way
to know if a resource has been explicitly marked `static`
by the user, and can therefore be assigned to.

This change is moves from making all resources `static` to adding Clang internal
linkage attribute to all non-static resource declarations as a global scope.
Existing tests verify that there is no change in how the resource globals are
emitted: `internal global`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications