[all-commits] [llvm/llvm-project] 8b4220: [mlir][ods] Enable basic string interpolation in c...

[Jacques Pienaar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8b422006af02766a0e1577108260200944106530
      https://github.com/llvm/llvm-project/commit/8b422006af02766a0e1577108260200944106530
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2025-11-07 (Fri, 07 Nov 2025)

  Changed paths:
    M mlir/include/mlir/TableGen/CodeGenHelpers.h
    M mlir/lib/TableGen/CodeGenHelpers.cpp
    M mlir/test/mlir-tblgen/constraint-unique.td
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/test/mlir-tblgen/op-properties-predicates.td
    M mlir/test/mlir-tblgen/predicate.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/unittests/TableGen/CMakeLists.txt

  Log Message:
  -----------
  [mlir][ods] Enable basic string interpolation in constraint summary. (#153603)

This enables printing, for example, the attribute value from a
mismatched predicate. Example of resultant output (here made
non-negative report value seen as sign-extended int):

```
PDL/ops.mlir:21:1: error: 'pdl.pattern' op attribute 'benefit' failed to satisfy constraint: 16-bit signless integer attribute whose value is non-negative (got -31)
pdl.pattern @rewrite_with_args : benefit(-31) {
^
```

This is primarily the mechanism and didn't change any existing
constraints. I also attempted to keep the error format as close to the
original as possible - but did notice 2 errors that were inconsistent
with the rest and updated them to be consistent.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications