[all-commits] [llvm/llvm-project] ad723f: [LLVM] Check if LLVM_ON_UNIX is Defined

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ad723f940980d94ee72084571c9fb06e46659b76
      https://github.com/llvm/llvm-project/commit/ad723f940980d94ee72084571c9fb06e46659b76
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M llvm/include/llvm/Support/thread.h

  Log Message:
  -----------
  [LLVM] Check if LLVM_ON_UNIX is Defined

This is canonical in the rest of the repository and otherwise we can end
up with warnings when compiling with clang-cl on Windows that look like
the following:

```
2025-11-06T17:55:25.2412502Z C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/thread.h(37,5): warning: 'LLVM_ON_UNIX' is not defined, evaluates to 0 [-Wundef]
2025-11-06T17:55:25.2413436Z    37 | #if LLVM_ON_UNIX || _WIN32
2025-11-06T17:55:25.2413791Z       |     ^
2025-11-06T17:55:25.2414625Z C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/thread.h(52,5): warning: 'LLVM_ON_UNIX' is not defined, evaluates to 0 [-Wundef]
2025-11-06T17:55:25.2415585Z    52 | #if LLVM_ON_UNIX
2025-11-06T17:55:25.2415901Z       |     ^
2025-11-06T17:55:25.2416169Z 2 warnings generated.
```

Reviewers: joker-eph, pcc, cachemeifyoucan

Reviewed By: cachemeifyoucan

Pull Request: https://github.com/llvm/llvm-project/pull/166827



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications