[all-commits] [llvm/llvm-project] b21949: Revert "[mlir][memref]: Collapse strided unit dim ...

[Han-Chung Wang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b21949eb34037aa1811cc55609ab46c577feab63
      https://github.com/llvm/llvm-project/commit/b21949eb34037aa1811cc55609ab46c577feab63
  Author: Han-Chung Wang <hanhan0912 at gmail.com>
  Date:   2025-11-04 (Tue, 04 Nov 2025)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/test/Dialect/MemRef/ops.mlir

  Log Message:
  -----------
  Revert "[mlir][memref]: Collapse strided unit dim even if strides are dynamic" (#166448)

Reverts llvm/llvm-project#157330

The original revision introduces a bug in `isGuaranteedCollapsible`. The
`memref<3x3x1x96xf32, strided<[288, 96, 96, 1], offset: 864>>` is no
longer collapsable with the change. The revision reverts the change to
bring back correct behavior. `stride` should be computed as `96` like
the old behavior in the failed iteration.


https://github.com/llvm/llvm-project/blob/92a1eb37122fa24e3045fbabdea2bf87127cace5/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp#L2597-L2605



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications