[all-commits] [llvm/llvm-project] f78b96: [Offload] Add device UID

Robert Imschweiler via All-commits all-commits at lists.llvm.org
Mon Nov 3 07:48:13 PST 2025


  Branch: refs/heads/users/ro-i/fix-callbr-amdgpu_2
  Home:   https://github.com/llvm/llvm-project
  Commit: f78b96a22bb68d3c9104a86c5b6299b9e6f6f7e1
      https://github.com/llvm/llvm-project/commit/f78b96a22bb68d3c9104a86c5b6299b9e6f6f7e1
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/liboffload/API/Device.td
    M offload/liboffload/src/OffloadImpl.cpp
    M offload/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/common/src/PluginInterface.cpp
    M offload/plugins-nextgen/host/src/rtl.cpp
    M offload/tools/deviceinfo/llvm-offload-device-info.cpp
    M offload/unittests/OffloadAPI/device/olGetDeviceInfo.cpp
    M offload/unittests/OffloadAPI/device/olGetDeviceInfoSize.cpp

  Log Message:
  -----------
  [Offload] Add device UID

Introduced in OpenMP 6.0, the device UID shall be a unique identifier of
a device on a given system. (Not necessarily a UUID.)
Since it is not guaranteed that the (U)UIDs defined by the device vendor
libraries, such as HSA, do not overlap with those of other vendors, the
device UIDs in offload are always combined with the offload plugin name.
In case the vendor library does not specify any device UID for a given
device, we fall back to the offload-internal device ID.
Note that the "fake" multiple host devices do *not* get different UIDs
because they are effectively the same device.
The device UID can be retrieved using the `llvm-offload-device-info`
tool.


  Commit: a1557f53f0177f8eb047d857f8f120bf0163e2c3
      https://github.com/llvm/llvm-project/commit/a1557f53f0177f8eb047d857f8f120bf0163e2c3
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/common/src/PluginInterface.cpp

  Log Message:
  -----------
  align use of auto to the file


  Commit: 31954a74c80a062ecadfc71e663b69329f2b9075
      https://github.com/llvm/llvm-project/commit/31954a74c80a062ecadfc71e663b69329f2b9075
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/common/src/PluginInterface.cpp
    M offload/plugins-nextgen/cuda/dynamic_cuda/cuda.cpp
    M offload/plugins-nextgen/cuda/dynamic_cuda/cuda.h
    M offload/plugins-nextgen/cuda/src/rtl.cpp

  Log Message:
  -----------
  add cuda UID


  Commit: 0517116246e9800ba76ca567a67c365afcd4f646
      https://github.com/llvm/llvm-project/commit/0517116246e9800ba76ca567a67c365afcd4f646
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/liboffload/src/OffloadImpl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/host/src/rtl.cpp

  Log Message:
  -----------
  add device UID getter to plugin


  Commit: e16d760cf1c37758410360edee1174f5c3c12622
      https://github.com/llvm/llvm-project/commit/e16d760cf1c37758410360edee1174f5c3c12622
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/liboffload/src/OffloadImpl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/host/src/rtl.cpp

  Log Message:
  -----------
  make virtual host devices have UIDs different from the initial device


  Commit: de4ac409d2494a66a2b1a668929640988e9d503a
      https://github.com/llvm/llvm-project/commit/de4ac409d2494a66a2b1a668929640988e9d503a
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/common/include/PluginInterface.h

  Log Message:
  -----------
  fix const getDevice() call


  Commit: 3749cb6022e231f792bc0f5f7c2c09c6f097d945
      https://github.com/llvm/llvm-project/commit/3749cb6022e231f792bc0f5f7c2c09c6f097d945
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/common/src/PluginInterface.cpp
    M offload/plugins-nextgen/cuda/dynamic_cuda/cuda.h
    M offload/plugins-nextgen/cuda/src/rtl.cpp

  Log Message:
  -----------
  fix cuda plugin UID


  Commit: bedeb5e0d1f96ab94dfeb1711f13e402909d3a49
      https://github.com/llvm/llvm-project/commit/bedeb5e0d1f96ab94dfeb1711f13e402909d3a49
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/cuda/src/rtl.cpp

  Log Message:
  -----------
  capitalize UUID; use StringRef::ends_with


  Commit: 7f53eabbbaea044e63fb42d1670fe503a6b28166
      https://github.com/llvm/llvm-project/commit/7f53eabbbaea044e63fb42d1670fe503a6b28166
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/liboffload/src/OffloadImpl.cpp
    M offload/plugins-nextgen/common/include/PluginInterface.h

  Log Message:
  -----------
  rename getInitialDeviceUid to getHostDeviceUid again


  Commit: 7cc656d8695b2aea45c3e12b6fe3737333b8d4eb
      https://github.com/llvm/llvm-project/commit/7cc656d8695b2aea45c3e12b6fe3737333b8d4eb
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/common/include/PluginInterface.h

  Log Message:
  -----------
  duplicate getDevice() implementation to avoid const_cast


  Commit: 5683075e39b1e2310169a1398f6e34a9ba9ab452
      https://github.com/llvm/llvm-project/commit/5683075e39b1e2310169a1398f6e34a9ba9ab452
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/plugins-nextgen/common/include/PluginInterface.h

  Log Message:
  -----------
  remove plugin-level getDeviceUid()


  Commit: e04b557169ee298482f74f06e793bf85b0006624
      https://github.com/llvm/llvm-project/commit/e04b557169ee298482f74f06e793bf85b0006624
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/include/OpenMP/omp.h
    M offload/include/omptarget.h
    M offload/libomptarget/OpenMP/API.cpp
    M offload/libomptarget/exports
    A offload/test/api/omp_device_uid.c
    M openmp/device/include/DeviceTypes.h
    M openmp/device/include/Interface.h
    M openmp/device/src/State.cpp
    M openmp/runtime/src/dllexports
    M openmp/runtime/src/include/omp.h.var
    M openmp/runtime/src/include/omp_lib.F90.var
    M openmp/runtime/src/include/omp_lib.h.var
    M openmp/runtime/src/kmp_ftn_entry.h
    M openmp/runtime/src/kmp_ftn_os.h
    A openmp/runtime/test/api/omp_device_uid.c

  Log Message:
  -----------
  [OpenMP] Implement omp_get_uid_from_device() / omp_get_device_from_uid()

Use the implementation in libomptarget. If libomptarget is not
available, always return the UID / device number of the host / the
initial device.


  Commit: 000cd6c38f94f6e350d33abbea4614b745566961
      https://github.com/llvm/llvm-project/commit/000cd6c38f94f6e350d33abbea4614b745566961
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/libomptarget/OpenMP/API.cpp
    M openmp/device/include/DeviceTypes.h
    M openmp/runtime/src/kmp_ftn_entry.h

  Log Message:
  -----------
  implement feedback


  Commit: 69e61dfe768433b2353ac634d5e227d2ed0a8526
      https://github.com/llvm/llvm-project/commit/69e61dfe768433b2353ac634d5e227d2ed0a8526
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/libomptarget/OpenMP/API.cpp

  Log Message:
  -----------
  adapt to offload plugin device UID getter


  Commit: eed9b956792e05fd7b4c39728be31e2aedb6c6ad
      https://github.com/llvm/llvm-project/commit/eed9b956792e05fd7b4c39728be31e2aedb6c6ad
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/libomptarget/OpenMP/API.cpp

  Log Message:
  -----------
  adapt to offload API


  Commit: a8b09cfa12aedf6b11177b8b08e6f185f9db41a3
      https://github.com/llvm/llvm-project/commit/a8b09cfa12aedf6b11177b8b08e6f185f9db41a3
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M openmp/runtime/src/kmp_ftn_entry.h

  Log Message:
  -----------
  fix libomptarget symbol lookup similar to how other functions handle it


  Commit: 944b974b7f805b989ceaccdec2f56247cad99947
      https://github.com/llvm/llvm-project/commit/944b974b7f805b989ceaccdec2f56247cad99947
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/test/api/omp_device_uid.c
    M openmp/runtime/test/api/omp_device_uid.c

  Log Message:
  -----------
  adapt tests


  Commit: 6fffb00ce400f7a9631c0692aa8b54bdd6b5fbd6
      https://github.com/llvm/llvm-project/commit/6fffb00ce400f7a9631c0692aa8b54bdd6b5fbd6
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/libomptarget/OpenMP/API.cpp

  Log Message:
  -----------
  rename getInitialDeviceUid to getHostDeviceUid again


  Commit: d6cbb687f2c7cf63651799eb83fab10aa0c01b31
      https://github.com/llvm/llvm-project/commit/d6cbb687f2c7cf63651799eb83fab10aa0c01b31
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M offload/libomptarget/OpenMP/API.cpp

  Log Message:
  -----------
  remove plugin-level getDeviceUid()


  Commit: 03565e51e68e9dd260db7991d0ddd1a591eba24d
      https://github.com/llvm/llvm-project/commit/03565e51e68e9dd260db7991d0ddd1a591eba24d
  Author: Robert Imschweiler <robert.imschweiler at amd.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp

  Log Message:
  -----------
  [AMDGPUUnifyDivergentExitNodes] Fix changed flag for expensive checks.

Adds forgotten flag update to
https://github.com/llvm/llvm-project/pull/152161.


Compare: https://github.com/llvm/llvm-project/compare/f78b96a22bb6%5E...03565e51e68e

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list