[all-commits] [llvm/llvm-project] d7e44d: [libcxx][modules] Fix missing includes for windows...

[Matt via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d7e44dc6a2067403509315d3fb4b20a9c6a68249
      https://github.com/llvm/llvm-project/commit/d7e44dc6a2067403509315d3fb4b20a9c6a68249
  Author: Matt <msta at google.com>
  Date:   2025-11-03 (Mon, 03 Nov 2025)

  Changed paths:
    M libcxx/include/__new/align_val_t.h
    M libcxx/include/__new/exceptions.h

  Log Message:
  -----------
  [libcxx][modules] Fix missing includes for windows (#158781)

Previously, I was getting the following error when attempting to compile
libc++ on windows with modules enabled.

```
While building module 'std':
In file included from <module-includes>:1:
In file included from gen/third_party/libc++/src/include/algorithm:1865:
In file included from gen/third_party/libc++/src/include/__algorithm/inplace_merge.h:28:
In file included from gen/third_party/libc++/src/include/__memory/unique_temporary_buffer.h:17:
In file included from gen/third_party/libc++/src/include/__memory/allocator.h:19:
gen/third_party/libc++/src/include/__new/allocate.h(40,73): error: 
      declaration of 'align_val_t' must be imported from module
      'sys_stage1.sysroot_vcruntime_new_h' before it is required
   40 |     return static_cast<_Tp*>(__builtin_operator_new(__size, static_cast<align_val...
      |                                                                         ^
../../third_party/depot_tools/win_toolchain/vs_files/e4305f407e/VC/Tools/MSVC/14.44.35207/include/vcruntime_new.h(27,33): note: 
      declaration here is not visible
   27 |     _VCRT_EXPORT_STD enum class align_val_t : size_t {};
      |                                 ^
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications