[all-commits] [llvm/llvm-project] 792c65: [MC] Fix accidentally eating the newline when hand...

Amara Emerson via All-commits all-commits at lists.llvm.org
Sat Oct 25 22:51:42 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 792c65c39f9ecf0d1bb36e846583470c492b3fca
      https://github.com/llvm/llvm-project/commit/792c65c39f9ecf0d1bb36e846583470c492b3fca
  Author: Amara Emerson <amara at apple.com>
  Date:   2025-10-25 (Sat, 25 Oct 2025)

  Changed paths:
    M llvm/lib/MC/MCParser/AsmLexer.cpp
    A llvm/test/MC/AsmParser/comments-x86-darwin-eol-dropped.s

  Log Message:
  -----------
  [MC] Fix accidentally eating the newline when handling a comment char at the end of the line. (#165129)

If we have a target where both # and ## are valid comment strings,
a line ending in # would trigger the lexer to eat 2 characters
and therefore lex the _next_ line as a comment. Oops. This was introduced
in 4946db15a74b761c5ac4ead18873639236b4ab5d

rdar://162635338



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list