[all-commits] [llvm/llvm-project] e2ad55: [Flang][mlir] - Translation of delayed privatizati...

[Pranav Bhandarkar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e2ad55499197db540d09e7201b9b80366a0908c3
      https://github.com/llvm/llvm-project/commit/e2ad55499197db540d09e7201b9b80366a0908c3
  Author: Pranav Bhandarkar <pranav.bhandarkar at amd.com>
  Date:   2025-10-22 (Wed, 22 Oct 2025)

  Changed paths:
    M flang/include/flang/Optimizer/Passes/Pipelines.h
    M flang/lib/Optimizer/Passes/Pipelines.cpp
    M flang/test/Fir/basic-program.fir
    M mlir/include/mlir/Dialect/OpenMP/CMakeLists.txt
    A mlir/include/mlir/Dialect/OpenMP/Transforms/CMakeLists.txt
    A mlir/include/mlir/Dialect/OpenMP/Transforms/Passes.h
    A mlir/include/mlir/Dialect/OpenMP/Transforms/Passes.td
    M mlir/lib/Dialect/LLVMIR/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/OpenMP/CMakeLists.txt
    A mlir/lib/Dialect/OpenMP/Transforms/CMakeLists.txt
    A mlir/lib/Dialect/OpenMP/Transforms/OpenMPOffloadPrivatizationPrepare.cpp
    M mlir/lib/RegisterAllPasses.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Dialect/OpenMP/omp-offload-privatization-prepare-by-value.mlir
    A mlir/test/Dialect/OpenMP/omp-offload-privatization-prepare.mlir
    M mlir/test/Target/LLVMIR/openmp-todo.mlir

  Log Message:
  -----------
  [Flang][mlir] - Translation of delayed privatization for deferred target-tasks (#155348)

This PR adds support for translation of the private clause on deferred
target tasks - that is `omp.target` operations with the `nowait` clause.

An offloading call for a deferred target-task is not blocking - the
offloading (target-generating) host task continues its execution after issuing the offloading
call. Therefore, the key problem we need to solve is to ensure that the
data needed for private variables to be initialized in the target task
persists even after the host task has completed.
We do this in a new pass called `PrepareForOMPOffloadPrivatizationPass`.
For a privatized variable that needs its host counterpart for
initialization (such as the shape of the data from the descriptor when
an allocatable is privatized or the value of the data when an
allocatable is firstprivatized),
  - the pass allocates memory on the heap.
- it then initializes this memory by using the `init` and `copy` (for
firstprivate) regions of the corresponding `omp::PrivateClauseOp`.
- Finally the memory allocated on the heap is freed using the `dealloc`
region of the same `omp::PrivateClauseOp` instance. This step is not
straightforward though, because we cannot simply free the memory that's
going to be used by another thread without any synchronization. So, for
deallocation, we create a `omp.task` after the `omp.target` and
synchronize the two with a dummy dependency (using the `depend` clause).
In this newly created `omp.task` we do the deallocation.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications