[all-commits] [llvm/llvm-project] c1852a: [AMDGPU][SIMemoryLegalizer][GFX12] Correctly inser...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1852afa4b1ebb17f101b9105d36ace700981dac
      https://github.com/llvm/llvm-project/commit/c1852afa4b1ebb17f101b9105d36ace700981dac
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2025-10-20 (Mon, 20 Oct 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-flat-agent.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-flat-cluster.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-flat-system.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-flat-workgroup.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-global-agent.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-global-cluster.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-global-system.ll
    M llvm/test/CodeGen/AMDGPU/memory-legalizer-global-workgroup.ll

  Log Message:
  -----------
  [AMDGPU][SIMemoryLegalizer][GFX12] Correctly insert sample/bvhcnt (#161637)

The check used was not strong enough to prevent the insertion of sample/bvhcnt when they were not needed.
I assume SIInsertWaitCnts was trimming those away anyway, but this was a bug nonetheless.

We were inserting SAMPLE/BVHcnt waits in places where we only needed to wait on the previous atomic operation. Neither of these counter have any atomics associated with them.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications