[all-commits] [llvm/llvm-project] 377148: [libclc] Move functions definition from header clc...

[Wenju He via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 377148fd60df55e486dc72b26248006ae092725a
      https://github.com/llvm/llvm-project/commit/377148fd60df55e486dc72b26248006ae092725a
  Author: Wenju He <wenju.he at intel.com>
  Date:   2025-10-20 (Mon, 20 Oct 2025)

  Changed paths:
    M libclc/clc/include/clc/math/clc_sincos_helpers.inc
    M libclc/clc/include/clc/math/clc_sincos_helpers_fp64.inc
    R libclc/clc/include/clc/math/clc_sincos_piby4.h
    R libclc/clc/include/clc/math/clc_sincos_piby4.inc
    M libclc/clc/lib/generic/math/clc_cos.cl
    M libclc/clc/lib/generic/math/clc_cospi.cl
    M libclc/clc/lib/generic/math/clc_sin.cl
    M libclc/clc/lib/generic/math/clc_sincos_helpers.inc
    M libclc/clc/lib/generic/math/clc_sincos_helpers_fp64.inc
    M libclc/clc/lib/generic/math/clc_sinpi.cl
    M libclc/clc/lib/generic/math/clc_tan.cl
    M libclc/clc/lib/generic/math/clc_tanpi.cl

  Log Message:
  -----------
  [libclc] Move functions definition from header clc_sincos_piby4.inc into clc_sincos_helpers.cl (#164028)

inline functions defined in clc_sincos_piby4.inc miss static specifier
and are deleted by EliminateAvailableExternallyPass when not inlined.

This PR fix the problem by removing inline and moving function
definition
into clc/lib/generic/math/clc_sincos_helpers.cl. It makes sense to put
all sin/cos helpers definitions in one file clc_sincos_helpers.cl.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications