[all-commits] [llvm/llvm-project] 1c11c6: Fix MSVC compile error in BitstreamRemarkParser.h ...

[Justin Holewinski via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c11c6004c820bf43eb2356da93e7bc8cb38f51e
      https://github.com/llvm/llvm-project/commit/1c11c6004c820bf43eb2356da93e7bc8cb38f51e
  Author: Justin Holewinski <jholewinski at nvidia.com>
  Date:   2025-10-17 (Fri, 17 Oct 2025)

  Changed paths:
    M llvm/lib/Remarks/BitstreamRemarkParser.h

  Log Message:
  -----------
  Fix MSVC compile error in BitstreamRemarkParser.h when targeting C++17

The following errors are seen in our builds using MSVC 2022:

BitstreamRemarkParser.h(115): error C2990: 'llvm::remarks::BitstreamBlockParserHelper': non-class template has already been declared as a class template
BitstreamRemarkParser.h(66): note: see declaration of 'llvm::remarks::BitstreamBlockParserHelper'

This change fixes the build issue by adding an explicit template
argument to the `friend class` statements.

This issue is not seen if using `-std:c++20`, but we still support
building as C++17.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications