[all-commits] [llvm/llvm-project] f5885d: [lld] Reject --read-workers when lld is built with...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5885de2cd49785d666b909612e4ec18925abc5a
      https://github.com/llvm/llvm-project/commit/f5885de2cd49785d666b909612e4ec18925abc5a
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-10-17 (Fri, 17 Oct 2025)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/test/CMakeLists.txt
    A lld/test/MachO/read-workers-no-thread-support.s
    M lld/test/MachO/read-workers.s
    M lld/test/lit.cfg.py
    M lld/test/lit.site.cfg.py.in

  Log Message:
  -----------
  [lld] Reject --read-workers when lld is built without thread support (#163925)

Also expand the #ifdef to remove unused code in this configuration. As
suggested in
https://github.com/llvm/llvm-project/pull/147134#issuecomment-3328612158.

I have also:
* Expanded the error message to explain why it's not allowed.
* Added a test for the error.
* Marked the original test as unsupported when threads are disabled.

Fixes issues we have had on Armv8 with threading disabled where this
test would crash every so often.

This change will hopefully be superseded by #157917, but that has been
in review a long time and I want to make the bot stable again.

I could just disable the test, but I'd like lld to function properly in
general in the meantime too.

Co-authored-by: John Holdsworth <github at johnholdsworth.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications