[all-commits] [llvm/llvm-project] dfdee9: [clang][modules] Derive mtime from PCM timestamps, ...

[Jan Svoboda via All-commits]

  Branch: refs/heads/release/21.x
  Home:   https://github.com/llvm/llvm-project
  Commit: dfdee9a929aa2d3ca75534da48f25076bc634bc5
      https://github.com/llvm/llvm-project/commit/dfdee9a929aa2d3ca75534da48f25076bc634bc5
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2025-10-16 (Thu, 16 Oct 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticSerializationKinds.td
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ModuleCache.cpp
    M clang/test/Modules/fmodules-validate-once-per-build-session.c

  Log Message:
  -----------
  [clang][modules] Derive mtime from PCM timestamps, not PCM files (#162965)

#137363 was supposed to be NFC for the `CrossProcessModuleCache` (a.k.a
normal implicit module builds), but accidentally passed the wrong path
to `sys::fs::status`. Then, #141358 removed the correct path that
should've been passed instead. (The variable was flagged as unused.)
None of our existing tests caught this regression, we only found out due
to a SourceKit-LSP benchmark getting slower.

This PR re-implements the original behavior, adds new remark to Clang
for PCM input file validation, and uses it to create more reliable tests
of the `-fmodules-validate-once-per-build-session` flag.

(cherry picked from commit ce8abef25e242e65e459bcb7d9998a4e85ae03d2)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications