[all-commits] [llvm/llvm-project] 995eb4: [lldb-dap] Add readOnly attribute for variables (#...

[Sergei Druzhkov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 995eb4ca2ee15daffcc5a20121de955a0e2ca023
      https://github.com/llvm/llvm-project/commit/995eb4ca2ee15daffcc5a20121de955a0e2ca023
  Author: Sergei Druzhkov <serzhdruzhok at gmail.com>
  Date:   2025-10-15 (Wed, 15 Oct 2025)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
    M lldb/tools/lldb-dap/ProtocolUtils.cpp

  Log Message:
  -----------
  [lldb-dap] Add readOnly attribute for variables (#151884)

This patch adds `readOnly`
[attribute](https://microsoft.github.io/debug-adapter-protocol/specification#Types_VariablePresentationHint)
for variables. When this attribute is returned for a variable, VS Code
prevents editing (and grays out the `Set Value` button). Without this,
users might be confused if the UI allows edits but the debug adapter
often returns an error. I checked `SetValueFromCString` function
implementation and found that it doesn't support aggregate data types,
so I added simple check for them. Also, I found that I can update value
of registers sets (but without any effects). So I also added checks for
those as well.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications