[all-commits] [llvm/llvm-project] 69194b: [NFC][OpenACC][CIR] Extract 'base' class for Recip...

Erich Keane via All-commits all-commits at lists.llvm.org
Fri Sep 26 06:34:02 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69194be7484adc707a16e09fdcfb3cdbc22d2074
      https://github.com/llvm/llvm-project/commit/69194be7484adc707a16e09fdcfb3cdbc22d2074
  Author: Erich Keane <ekeane at nvidia.com>
  Date:   2025-09-26 (Fri, 26 Sep 2025)

  Changed paths:
    A clang/lib/CIR/CodeGen/CIRGenOpenACCRecipe.cpp
    M clang/lib/CIR/CodeGen/CIRGenOpenACCRecipe.h
    M clang/lib/CIR/CodeGen/CMakeLists.txt

  Log Message:
  -----------
  [NFC][OpenACC][CIR] Extract 'base' class for Recipe generation (#160603)

It was brought up on a previous review that the CIRGenOpenACCRecipe.h
file was getting too large. I noticed that the 'dependent on template
argument' parts were actually quite small, so I extract a base class in
this patch that allows me to implement it in the .cpp file, plus
minimize the amount of code that needs instantiating.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list