[all-commits] [llvm/llvm-project] fea44a: [flang][OpenACC][NFC] remove legacy openacc-unwrap...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fea44afcbc7228f3be726bf0b259204f2a9fa8d7
      https://github.com/llvm/llvm-project/commit/fea44afcbc7228f3be726bf0b259204f2a9fa8d7
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-09-24 (Wed, 24 Sep 2025)

  Changed paths:
    M flang/lib/Lower/OpenACC.cpp
    M flang/test/Lower/OpenACC/acc-bounds.f90
    R flang/test/Lower/OpenACC/acc-data-operands-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-data-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-declare-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-enter-data-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-exit-data-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-host-data-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-private-unwrap-defaultbounds.f90
    R flang/test/Lower/OpenACC/acc-reduction-unwrap-defaultbounds.f90

  Log Message:
  -----------
  [flang][OpenACC][NFC] remove legacy openacc-unwrap-fir-box option (#160291)

Remove `openacc-unwrap-fir-box`.

I am working on a change that will map the acc data operation result to
the symbol so that accesses to variables that appeared in data clauses
inside a compute region are isolated from access to the variable outside
the region (using different SSA value).

This change will not work properly with the `openacc-unwrap-fir-box`
option that make the data operation result/operand a raw pointer, even
in cases where more information about the variable is needed to later
work with it.

It would likely be technically possible to reconstruct the variable from
the raw result. But this would add extra complexity to a legacy option.
I think it is better to remove it, and to work on some pass to "unbox"
as we can later (leveraging inlining).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications