[all-commits] [llvm/llvm-project] 9d48df: [UpdateTestChecks] Don't fail silently when confli...

[Alex Bradbury via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d48df7a92e723a0d1a8bd8c664988411ca530a1
      https://github.com/llvm/llvm-project/commit/9d48df7a92e723a0d1a8bd8c664988411ca530a1
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2025-09-23 (Tue, 23 Sep 2025)

  Changed paths:
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/conflicting-prefixes.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/conflicting-prefixes.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/differing-set-of-functions.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/differing-set-of-functions.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/conflicting-prefixes.test
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/differing-set-of-functions.test
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/prefix-never-matches.test
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  [UpdateTestChecks] Don't fail silently when conflicting CHECK lines means no checks are generated for some functions (#159321)

There is a warning that triggers if you (for instance) run
`update_llc_test_checks.py` on an input where _all_ functions have
conflicting check lines and so no checks are generated. However, there
are no warnings emitted at all for the case where some functions have
non-conflicting check lines but others don't. This is a source of
frustration because running update_llc_test_checks can result in all
check lines being removed for certain functions when such a conflict
exists with no warning, meaning we have to be extra vigilant inspecting
the diff. I've also personally wasted time tracking down the source of
the dropped lines assuming that update_test_checks would emit a warning
in such cases.

This change adds logic to emit warnings on a function-by-function basis
for any RUN that has conflicting prefixes meaning no output is
generated. This subsumes the previous warning for when _all_ functions
conflict.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications