[all-commits] [llvm/llvm-project] 1d381a: [MC][BPF] Avoid generating .note.GNU-stack section...

[yonghong-song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d381ac43b170998e9a9f7e8afa86dbc8d5a0253
      https://github.com/llvm/llvm-project/commit/1d381ac43b170998e9a9f7e8afa86dbc8d5a0253
  Author: yonghong-song <yhs at fb.com>
  Date:   2025-09-22 (Mon, 22 Sep 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCAsmInfoELF.h
    M llvm/lib/Target/BPF/MCTargetDesc/BPFMCAsmInfo.h

  Log Message:
  -----------
  [MC][BPF] Avoid generating .note.GNU-stack section (#159960)

The kernel libbpf does not need .note.GNU-stack section. If not
filtering out in llvm, the section will be filtered out in libbpf. So
let us filter it out as early as possible which is in llvm.

Change function getNonexecutableStackSection() in MCAsmInfoELF.h from
'final' to 'override' so target (e.g. BPF) can decide whether
'.note.GNU-stack' section should be emitted or not.

The following is an example.

  $ cat t.c
  int test() { return 5; }

Without this change:

  $ llvm-readelf -S t.o
  [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            0000000000000000 000000 000000 00      0   0  0
  [ 1] .strtab           STRTAB          0000000000000000 000110 000047 00      0   0  1
  [ 2] .text             PROGBITS        0000000000000000 000040 000010 00  AX  0   0  8
  [ 3] .comment          PROGBITS        0000000000000000 000050 000072 01  MS  0   0  1
  [ 4] .note.GNU-stack   PROGBITS        0000000000000000 0000c2 000000 00      0   0  1
  [ 5] .llvm_addrsig     LLVM_ADDRSIG    0000000000000000 000110 000000 00   E  6   0  1
  [ 6] .symtab           SYMTAB          0000000000000000 0000c8 000048 18      1   2  8

  $ llvm-readelf -S t.o
  [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            0000000000000000 000000 000000 00      0   0  0
  [ 1] .strtab           STRTAB          0000000000000000 000110 000037 00      0   0  1
  [ 2] .text             PROGBITS        0000000000000000 000040 000010 00  AX  0   0  8
  [ 3] .comment          PROGBITS        0000000000000000 000050 000072 01  MS  0   0  1
  [ 4] .llvm_addrsig     LLVM_ADDRSIG    0000000000000000 000110 000000 00   E  5   0  1
  [ 5] .symtab           SYMTAB          0000000000000000 0000c8 000048 18      1   2  8



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications