[all-commits] [llvm/llvm-project] b52992: [lld-link] Do not assert when reporting error abou...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b5299210f29da7432adaf3b48332c93b9cace3b0
      https://github.com/llvm/llvm-project/commit/b5299210f29da7432adaf3b48332c93b9cace3b0
  Author: Nico Weber <thakis at chromium.org>
  Date:   2025-09-20 (Sat, 20 Sep 2025)

  Changed paths:
    M lld/COFF/Driver.cpp

  Log Message:
  -----------
  [lld-link] Do not assert when reporting error about non-thin archive (#159828)

Follow-up to https://reviews.llvm.org/D57974, which added calls to
Archive::Child::getFullName() to produce strings in errors.

But getFullName() is only valid on thin archives, and should only be
used to open the file the archive points to. For diagnostics, getName()
is better: It works for both thin and non-thin files, and it doesn't
make a very long string for thin files. And we already prepend the name
of the parent archive file anyways.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications