[all-commits] [llvm/llvm-project] c1d838: [libc] fix error: implicit conversion loses floati...

Maksim Levental via All-commits all-commits at lists.llvm.org
Sat Sep 20 10:08:01 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1d838e6f21746a6839840a53db99f55d6370cdf
      https://github.com/llvm/llvm-project/commit/c1d838e6f21746a6839840a53db99f55d6370cdf
  Author: Maksim Levental <maksim.levental at gmail.com>
  Date:   2025-09-20 (Sat, 20 Sep 2025)

  Changed paths:
    M libc/test/shared/shared_math_test.cpp

  Log Message:
  -----------
  [libc] fix error: implicit conversion loses floating-point precision: 'double' to 'float' in shared_math_test.cpp (#159934)

This test fails under `-Werror=implicit-float-conversion` (like in our
pre-merge CI) because `dsqrtl` returns a double
https://github.com/llvm/llvm-project/blob/2b937daa1310f7c17a03a0a4a7abf83149e1dc71/libc/src/__support/math/dsqrtl.h#L18

Fixes https://github.com/llvm/llvm-project/issues/159932



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list