[all-commits] [llvm/llvm-project] 8d6470: [Clang] Make rewrite-includes-bom.c work with inte...

[Aiden Grossman via All-commits]

  Branch: refs/heads/users/boomanaiden154/clang-enable-lit-internal-shell-by-default
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d6470f717cb5c2d200f71dff09ee76a12f908a7
      https://github.com/llvm/llvm-project/commit/8d6470f717cb5c2d200f71dff09ee76a12f908a7
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-09-19 (Fri, 19 Sep 2025)

  Changed paths:
    M clang/test/Frontend/rewrite-includes-bom.c

  Log Message:
  -----------
  [Clang] Make rewrite-includes-bom.c work with internal shell

This test was using $'<content with escapes' to have bash interpret
shell escapes and then passing them to grep. The lexer/parser for lit's
internal shell does not support such sequences. Given this is the only
test in-tree that uses this functionality, it makes much more sense to
use a POSIX compliant utility like od to transform the file into hex and
then grep over that rather than modify the internal shell. This test
should remain portable as od should be widely available and we are only
using options specified in POSIX.

Reviewers: cmtice, petrhosek, ilovepi

Reviewed By: petrhosek, ilovepi

Pull Request: https://github.com/llvm/llvm-project/pull/158463


  Commit: ef6a2db88765ce9674b3e5fab8317a9e8732817a
      https://github.com/llvm/llvm-project/commit/ef6a2db88765ce9674b3e5fab8317a9e8732817a
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-09-20 (Sat, 20 Sep 2025)

  Changed paths:

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.6

[skip ci]


  Commit: 66e5cc73d3726eca401768a3c2beee3cede8bb00
      https://github.com/llvm/llvm-project/commit/66e5cc73d3726eca401768a3c2beee3cede8bb00
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-09-20 (Sat, 20 Sep 2025)

  Changed paths:

  Log Message:
  -----------
  rebase

Created using spr 1.3.6


Compare: https://github.com/llvm/llvm-project/compare/74a8c5ace433...66e5cc73d372

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications