[all-commits] [llvm/llvm-project] ac2b51: [C++20] [Modules] Fix issues with non-exported in-...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ac2b51e6ce157b430b3823ebc90def9f1d49d36e
      https://github.com/llvm/llvm-project/commit/ac2b51e6ce157b430b3823ebc90def9f1d49d36e
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2025-09-18 (Thu, 18 Sep 2025)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/pr133720.cppm
    A clang/test/Modules/pr159424.cppm

  Log Message:
  -----------
  [C++20] [Modules] Fix issues with non-exported in-class friend declarations

Close https://github.com/llvm/llvm-project/issues/159424
Close https://github.com/llvm/llvm-project/issues/133720

For in-class friend declaration, it is hard for the serializer to decide
if they are visible to other modules. But luckily, Sema can handle it
perfectly enough. So it is fine to make all of the in-class friend
declaration as generally visible in ASTWriter and let the Sema to make
the final call. This is safe as long as the corresponding class's
visibility are correct.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications