[all-commits] [llvm/llvm-project] c723cc: [Remarks] BitstreamRemarkParser: Refactor error ha...

Tobias Stadler via All-commits all-commits at lists.llvm.org
Mon Sep 15 07:22:22 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c723cc2a041d6e7e741b0ce6abc1f18d4ada9b4a
      https://github.com/llvm/llvm-project/commit/c723cc2a041d6e7e741b0ce6abc1f18d4ada9b4a
  Author: Tobias Stadler <mail at stadler-tobias.de>
  Date:   2025-09-15 (Mon, 15 Sep 2025)

  Changed paths:
    M llvm/lib/Remarks/BitstreamRemarkParser.cpp
    M llvm/lib/Remarks/BitstreamRemarkParser.h

  Log Message:
  -----------
  [Remarks] BitstreamRemarkParser: Refactor error handling (#156511)

In preparation of larger changes to the bitstream remark format,
refactor the error handling code in the BitstreamRemarkParser.

Main change: move the various static helper methods into the parser
helper classes, so we don't need to pass around as many args. Calling
`error(...)` inside the helper classes now automatically prepends the
current block being parsed to the error message.

NFCI (except for error messages on invalid bitstream files).

Pull Request: https://github.com/llvm/llvm-project/pull/156511



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list