[all-commits] [llvm/llvm-project] 3f4eb8: [cland-tidy][NFC] Fixed documentation for moderniz...

[0xdeadbeaf via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f4eb814452e243ceef6e04494f6525dc8ce13e6
      https://github.com/llvm/llvm-project/commit/3f4eb814452e243ceef6e04494f6525dc8ce13e6
  Author: 0xdeadbeaf <0xdeadbeaf at tutamail.com>
  Date:   2025-09-13 (Sat, 13 Sep 2025)

  Changed paths:
    M clang-tools-extra/docs/clang-tidy/checks/modernize/make-shared.rst

  Log Message:
  -----------
  [cland-tidy][NFC] Fixed documentation for modernize-make-shared check (#158421)

I was surprised to see a different value for the
`MakeSmartPtrFunctionHeader` option of the `modernize-make-unique` and
`modernize-make-shared` clang-tidy checks. See, respectively:
[modernize-make-unique](https://github.com/llvm/llvm-project/blob/86397f55d5b3ac2ebefc91bbf1a7a6a23b44a3e2/clang-tools-extra/docs/clang-tidy/checks/modernize/make-unique.rst?plain=1#L40)
and
[modernize-make-shared](https://github.com/llvm/llvm-project/blob/86397f55d5b3ac2ebefc91bbf1a7a6a23b44a3e2/clang-tools-extra/docs/clang-tidy/checks/modernize/make-shared.rst?plain=1#L40).

>From what I've read in the codebase, I believe both checks use the same
default value for the `MakeSmartPtrFunctionHeader`: `<memory>` (from
[here](https://github.com/llvm/llvm-project/blob/d976be0bb4f706a7f8d446cd5639651db66bf7a9/clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp#L45-L46)).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications