[all-commits] [llvm/llvm-project] 13daa1: [lldb-dap] Add `debugAdapterEnv` for `attach` requ...

[Roy Shi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 13daa1e6efdbdc322265fda7ad8f5b265d2ab4aa
      https://github.com/llvm/llvm-project/commit/13daa1e6efdbdc322265fda7ad8f5b265d2ab4aa
  Author: Roy Shi <royitaqi at users.noreply.github.com>
  Date:   2025-09-11 (Thu, 11 Sep 2025)

  Changed paths:
    M lldb/tools/lldb-dap/package.json
    M lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts

  Log Message:
  -----------
  [lldb-dap] Add `debugAdapterEnv` for `attach` requests & improve regex (#157980)

# Changes

#153536 added a new debug configuration field called `debugAdapterEnv`
and enabled it in `launch.json` **for `launch` requests**. This patch
enables the same for **`attach` requests**.

This patch also improves the regex used in this field, i.e. shortens it
and fixes the double backslashes (`\\`) in `debug-adapter-factory.ts`
(note: the ones in `package.json` need the double backslashes).


# Test

Manually tested the following values in `attach` requests (so that we
are testing both changes at the same time):
```
// Accepted
            "debugAdapterEnv": [
                "AAA=BBB",
            ],

            "debugAdapterEnv": [
                "AAA=",
            ],

            "debugAdapterEnv": [
                "AAA",
            ],

 // Rejected
            "debugAdapterEnv": [
                "=AAA",
            ],

            "debugAdapterEnv": [
                "=",
            ],

            "debugAdapterEnv": [
                "",
            ],
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications