[all-commits] [llvm/llvm-project] 657877: [LLDB][NativePDB] Implement `AddSymbols` (#154121)

[nerix via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 65787728b72a2b1f1bfdefd15d32ec0a69f2b941
      https://github.com/llvm/llvm-project/commit/65787728b72a2b1f1bfdefd15d32ec0a69f2b941
  Author: nerix <nerixdev at outlook.de>
  Date:   2025-09-11 (Thu, 11 Sep 2025)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    M lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
    M lldb/test/Shell/SymbolFile/NativePDB/inline_sites.test
    M lldb/test/Shell/SymbolFile/NativePDB/local-variables-registers.s
    M lldb/test/Shell/SymbolFile/NativePDB/nested-blocks-same-address.s
    A lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp
    M lldb/test/Shell/Unwind/windows-unaligned-x86_64.test

  Log Message:
  -----------
  [LLDB][NativePDB] Implement `AddSymbols` (#154121)

This PR implements `SymbolFileNativePDB::AddSymbols` which adds public
symbols to the symbol table.

These symbols are found in the publics stream. It contains mangled names
coupled with addresses. Addresses are a pair of (segment, offset).
If I understood correctly, then the segment is the section ID from the
COFF header. Sections are already
[constructed](https://github.com/llvm/llvm-project/blob/c48ec7fb60b5e0b4100731d75f82ea63c0ec7b45/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp#L1048)
using this 1-based index ([MS
docs](https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#section-table-section-headers)).
This allows us to use `section_list->FindSectionByID`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications