[all-commits] [llvm/llvm-project] 820f44: [lldb] Correct style of error messages (#156774)

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Sep 4 16:38:03 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 820f4402745dda82fca482f2b83925e2953e6ad9
      https://github.com/llvm/llvm-project/commit/820f4402745dda82fca482f2b83925e2953e6ad9
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2025-09-04 (Thu, 04 Sep 2025)

  Changed paths:
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/Commands/CommandObjectBreakpoint.cpp
    M lldb/source/Commands/CommandObjectCommands.cpp
    M lldb/source/Commands/CommandObjectFrame.cpp
    M lldb/source/Commands/CommandObjectLog.cpp
    M lldb/source/Commands/CommandObjectMultiword.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Commands/CommandObjectSource.cpp
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Commands/CommandObjectThread.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Commands/CommandObjectWatchpointCommand.cpp
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/source/Expression/DWARFExpressionList.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Interpreter/CommandObject.cpp
    M lldb/source/Interpreter/Options.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
    M lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp
    M lldb/test/API/commands/command/script/add/TestAddParsedCommand.py
    M lldb/test/API/commands/frame/select/TestFrameSelect.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/invalid-vector/TestDataFormatterLibcxxInvalidVectorSimulator.py
    M lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
    M lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
    M lldb/test/API/functionalities/multiword-commands/TestMultiWordCommands.py
    M lldb/test/API/python_api/interpreter/TestRunCommandInterpreterAPI.py
    M lldb/unittests/API/SBCommandInterpreterTest.cpp

  Log Message:
  -----------
  [lldb] Correct style of error messages (#156774)

The LLVM Style Guide says the following about error and warning messages
[1]:

> [T]o match error message styles commonly produced by other tools,
> start the first sentence with a lowercase letter, and finish the last
> sentence without a period, if it would end in one otherwise.

I often provide this feedback during code review, but we still have a
bunch of places where we have inconsistent error message, which bothers
me as a user. This PR identifies a handful of those places and updates
the messages to be consistent.

[1] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list