[all-commits] [llvm/llvm-project] 3b3fc7: [lldb][RISCV][test] make atomic region stepping te...

[dlav-sc via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b3fc701d8f83d4ca30ee1c818fb7687336ac178
      https://github.com/llvm/llvm-project/commit/3b3fc701d8f83d4ca30ee1c818fb7687336ac178
  Author: dlav-sc <daniil.avdeev at syntacore.com>
  Date:   2025-09-03 (Wed, 03 Sep 2025)

  Changed paths:
    M lldb/test/API/riscv/step/TestSoftwareStep.py
    M lldb/test/API/riscv/step/branch.c
    M lldb/test/API/riscv/step/incomplete_sequence_without_lr.c
    M lldb/test/API/riscv/step/incomplete_sequence_without_sc.c
    M lldb/test/API/riscv/step/main.c

  Log Message:
  -----------
  [lldb][RISCV][test] make atomic region stepping test more robust (#156506)

Currently, the tests that check stepping through atomic sequences use a
hardcoded step distance, which is unreliable because this distance
depends on LLVM's codegeneration. The relocations that clang emits can
change the distance of the step.

Additionally, it was a poor idea to compute and check the step distance
because that is not what we should actually be verifying. In the tests
we already know where execution should stop after the step - for
example, at a branch instruction - therefore, it is better to check the
opcode of the instruction rather than the step distance. The step
distance itself is not important and can sometimes be misleading.

This patch rewrites the tests, so now they checks the opcode of the
instruction after the step instead of the step distance.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications