[all-commits] [llvm/llvm-project] 1cee0e: [lldb][windows] use Windows APIs to print to the c...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1cee0e7b6281e5f82154a101eed09a7197a295a6
      https://github.com/llvm/llvm-project/commit/1cee0e7b6281e5f82154a101eed09a7197a295a6
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2025-09-03 (Wed, 03 Sep 2025)

  Changed paths:
    M lldb/include/lldb/Host/File.h
    M lldb/source/Host/common/File.cpp

  Log Message:
  -----------
  [lldb][windows] use Windows APIs to print to the console (#156469)

This is a relanding of https://github.com/llvm/llvm-project/pull/149493.
The tests were failing because we were interpreting a proper file
descriptor as a console file descriptor.

This patch uses the Windows APIs to print to the Windows Console,
through `llvm::raw_fd_ostream`.

This fixes a rendering issue where the characters defined in
`DiagnosticsRendering.cpp` ("╰" for instance) are not rendered properly
on Windows out of the box, because the default codepage is not `utf-8`.

This solution is based on [this patch
downstream](https://github.com/swiftlang/swift/pull/40632/files#diff-e948e4bd7a601e3ca82d596058ccb39326459a4751470eec4d393adeaf516977R37-R38).

rdar://156064500



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications