[all-commits] [llvm/llvm-project] ab6ff0: [CIR][NFC] Add errors for unhandled AggExprEmitter...

[Andy Kaylor via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab6ff0e432621b9bd8154e3b293908ff3fa93041
      https://github.com/llvm/llvm-project/commit/ab6ff0e432621b9bd8154e3b293908ff3fa93041
  Author: Andy Kaylor <akaylor at nvidia.com>
  Date:   2025-08-27 (Wed, 27 Aug 2025)

  Changed paths:
    M clang/include/clang/CIR/MissingFeatures.h
    M clang/lib/CIR/CodeGen/CIRGenExprAggregate.cpp
    M clang/test/CIR/CodeGen/statement-exprs.c
    M clang/test/CIR/CodeGenOpenACC/compute-firstprivate-clause.c

  Log Message:
  -----------
  [CIR][NFC] Add errors for unhandled AggExprEmitter visitors (#155469)

There are a lot of required handlers in AggExprEmitter that are
currently missing. Because the ASTVisitor has fallbacks, this means we
just silently ignore whatever expressions are not explicitly handled.
This patch adds handlers where we know they will be needed and just
issues a diagnostic.

This exposed failures in a few tests. In one case, we should have
handled constant initialization earlier, which would have avoided going
to the AggExprEmitter at all. I added a stub with a missing feature
marker to allow that case to work as it had. Another test required us to
ignore cast expressions that should be ignored, so I partially
implemented the cast visitor. Finally, there's a case where the test was
just accepting a bad result. I changed that case to XFAIL until it can
be properly fixed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications