[all-commits] [llvm/llvm-project] ecc3a8: [ThreadPool] Fix Windows failures in the AffinityM...
Andrew Ng via All-commits
all-commits at lists.llvm.org
Wed Aug 27 06:27:23 PDT 2025
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ecc3a804263556b1ccf29118da3d9f9b642386e4
https://github.com/llvm/llvm-project/commit/ecc3a804263556b1ccf29118da3d9f9b642386e4
Author: Andrew Ng <andrew.ng at sony.com>
Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths:
M llvm/unittests/Support/ThreadPool.cpp
Log Message:
-----------
[ThreadPool] Fix Windows failures in the AffinityMask unit test (#155614)
These thread pool tests are typed and one was failing due to the setting
of environment variable `LLVM_THREADPOOL_AFFINITYMASK` leaking out of a
previous run of the test. I suspect that this has mainly succeeded
because the tests have run in separate shards.
Also the re-invocation of the unit test with the process affinity mask
set was not actually running the test because `--gtest_filter=` was not
set correctly. This has been fixed.
The use of the test type (TypeParam) in the AsyncBarrier test has been
restored. Without this the typing of these tests would be completely
redundant.
I suspect that some of these unit tests do not work if
`LLVM_ENABLE_THREADS == 0` but that is beyond the scope of this fix.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list