[all-commits] [llvm/llvm-project] e16231: AMDGPU: Fix fixme for out of bounds indexing in us...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Aug 27 05:03:25 PDT 2025


  Branch: refs/heads/users/arsenm/amdgpu/fix-oob-constant-bus-check
  Home:   https://github.com/llvm/llvm-project
  Commit: e16231adb5f207d67f036acbce4faee84631127d
      https://github.com/llvm/llvm-project/commit/e16231adb5f207d67f036acbce4faee84631127d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-08-27 (Wed, 27 Aug 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.h

  Log Message:
  -----------
  AMDGPU: Fix fixme for out of bounds indexing in usesConstantBus check

This loop over all the operands in the MachineInstr will eventually
go past the end of the MCInstrDesc's explicit operands. We don't
need the instr desc to compute the constant bus usage, just the
register and whether it's implicit or not. The check here is slightly
conservative. e.g. a random vcc implicit use appended to an instruction
will falsely report a constant bus use.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list