[all-commits] [llvm/llvm-project] 35110b: [mlir] Consistently add TableGen generated files a...

[Bryan Tan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35110b7b10134f7f5008f8f55ab0f190198d9874
      https://github.com/llvm/llvm-project/commit/35110b7b10134f7f5008f8f55ab0f190198d9874
  Author: Bryan Tan <Technius at users.noreply.github.com>
  Date:   2025-08-27 (Wed, 27 Aug 2025)

  Changed paths:
    M mlir/cmake/modules/AddMLIR.cmake
    M mlir/include/mlir/Conversion/CMakeLists.txt
    M mlir/include/mlir/Conversion/ConvertToLLVM/CMakeLists.txt
    M mlir/include/mlir/Dialect/AMDGPU/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/AMDGPU/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Affine/CMakeLists.txt
    M mlir/include/mlir/Dialect/Affine/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/Arith/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmNeon/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmNeon/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmSME/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmSME/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmSVE/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmSVE/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/ArmSVE/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Async/CMakeLists.txt
    M mlir/include/mlir/Dialect/Bufferization/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Bufferization/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/Bufferization/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Complex/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/DLTI/CMakeLists.txt
    M mlir/include/mlir/Dialect/DLTI/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/EmitC/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/EmitC/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Func/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Func/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/Func/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/GPU/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/GPU/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/GPU/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
    M mlir/include/mlir/Dialect/LLVMIR/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Linalg/CMakeLists.txt
    M mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Linalg/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/MLProgram/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/MPI/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Math/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/MemRef/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/MemRef/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/NVGPU/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/NVGPU/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/NVGPU/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/OpenACC/CMakeLists.txt
    M mlir/include/mlir/Dialect/OpenACC/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/OpenMP/CMakeLists.txt
    M mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Quant/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Quant/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/SCF/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/SCF/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/SCF/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/SMT/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/SPIRV/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/SPIRV/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Shape/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Shard/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Shard/Interfaces/CMakeLists.txt
    M mlir/include/mlir/Dialect/Shard/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/SparseTensor/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/SparseTensor/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/SparseTensor/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Tensor/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/Tensor/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Tosa/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Tosa/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/DebugExtension/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/IRDLExtension/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/Interfaces/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/LoopExtension/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/PDLExtension/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/Transform/TuneExtension/CMakeLists.txt
    M mlir/include/mlir/Dialect/UB/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Utils/CMakeLists.txt
    M mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/Vector/TransformOps/CMakeLists.txt
    M mlir/include/mlir/Dialect/Vector/Transforms/CMakeLists.txt
    M mlir/include/mlir/Dialect/WasmSSA/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/XeGPU/IR/CMakeLists.txt
    M mlir/include/mlir/Dialect/XeGPU/Transforms/CMakeLists.txt
    M mlir/include/mlir/IR/CMakeLists.txt
    M mlir/include/mlir/Interfaces/CMakeLists.txt
    M mlir/include/mlir/Reducer/CMakeLists.txt
    M mlir/include/mlir/Target/LLVMIR/Transforms/CMakeLists.txt
    M mlir/include/mlir/Transforms/CMakeLists.txt

  Log Message:
  -----------
  [mlir] Consistently add TableGen generated files as deps to `mlir-headers`/`mlir-generic-headers` CMake targets (#155474)

Tool targets like `mlir-opt` rely on the `mlir-headers` or
`mlir-generic-headers` targets to run first to generate headers.
However, many of the `IncGen` targets are not specified as dependencies
of the header targets in CMake, which causes spurious build failures when
using a high number of parallel build jobs.

Thus, this commit introduces a pair of new CMake macros
`add_mlir_dialect_tablegen_target` and
`add_mlir_generic_tablegen_target` to
`AddMLIR.cmake`, which can be used in place of
`add_public_tablegen_target` to
ensure (by convention) that `IncGen` targets are added to the
`mlir-headers`
(resp. `mlir-generic-headers`) target dependencies.

Most uses of `add_public_tablegen_target` in the dialects have been
refactored to use the new macros.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications