[all-commits] [llvm/llvm-project] f09986: [clang-format] Use proper flags for git diff-tree ...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f09986aab575b41e2e210d937a46dfce82eceebc
      https://github.com/llvm/llvm-project/commit/f09986aab575b41e2e210d937a46dfce82eceebc
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-08-26 (Tue, 26 Aug 2025)

  Changed paths:
    M clang/tools/clang-format/git-clang-format

  Log Message:
  -----------
  [clang-format] Use proper flags for git diff-tree (#155247)

>From local testing, git diff-tree does not support three dot diffs
correctly, instead expecting the --merge-base flag to be passed along
with two commits. From my reading, the documentation
(https://git-scm.com/docs/git-diff-tree) also confirms this. This patch
updates the git-clang-format script to be correct.

I don't think we ever ran into this issue before because we never ended
up using it. For the PR code format job I believe we would just
explicitly pass the merge base, completely bypassing the problem.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications