[all-commits] [llvm/llvm-project] 34109c: [flang][OpenMP] move omp end directive validation ...

[Tom Eccles via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34109cd26ae1b317d91c061500d9828fe6ebab0b
      https://github.com/llvm/llvm-project/commit/34109cd26ae1b317d91c061500d9828fe6ebab0b
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-08-26 (Tue, 26 Aug 2025)

  Changed paths:
    M flang/lib/Parser/openmp-parsers.cpp
    M flang/lib/Semantics/check-omp-structure.cpp
    M flang/test/Parser/OpenMP/fail-construct1.f90
    A flang/test/Parser/OpenMP/ordered-block-vs-standalone.f90
    A flang/test/Semantics/OpenMP/missing-end-directive.f90

  Log Message:
  -----------
  [flang][OpenMP] move omp end directive validation to semantics (#154739)

The old parse tree errors quckly exploded to thousands of unhelpful
lines when there were multiple missing end directives (e.g. #90452).

Instead I've added a flag to the parse tree indicating when a missing
end directive needs to be diagnosed, and moved the error messages to
semantics (where they are a lot easier to control).

This has the disadvantage of not displaying the error if there were
other parse errors, but there is a precedent for this approach (e.g.
parsing atomic constructs).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications