[all-commits] [llvm/llvm-project] 3996f1: [clang] remove isDefaulted bit from TemplateArgument

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/remove-template-arg-defaulted
  Home:   https://github.com/llvm/llvm-project
  Commit: 3996f1f23d55e5d3fa121a75e015ce7fbd3624ca
      https://github.com/llvm/llvm-project/commit/3996f1f23d55e5d3fa121a75e015ce7fbd3624ca
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-08-23 (Sat, 23 Aug 2025)

  Changed paths:
    M clang/include/clang/AST/PropertiesBase.td
    M clang/include/clang/AST/TemplateBase.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/ASTImporter.cpp
    M clang/lib/AST/TemplateBase.cpp
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/lib/CodeGen/CGDebugInfo.h
    M clang/lib/Sema/HLSLExternalSemaSource.cpp
    M clang/lib/Sema/SemaTemplate.cpp
    M clang/lib/Serialization/ASTWriterDecl.cpp
    M clang/test/DebugInfo/CXX/template-parameter.cpp
    M clang/test/DebugInfo/CXX/template.cpp
    M clang/test/DebugInfo/Generic/preferred_name-chain.cpp
    M clang/test/DebugInfo/Generic/preferred_name.cpp
    M clang/test/Modules/gmodules-preferred-name-typedef.cpp
    M clang/test/SemaCXX/cxx14-compat.cpp
    M clang/unittests/AST/ASTImporterTest.cpp
    M clang/unittests/AST/DeclTest.cpp
    M lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp

  Log Message:
  -----------
  [clang] remove isDefaulted bit from TemplateArgument

The IsDefaulted bit being part of a canonical TemplateArgument
doesn't make sense, as that information is not information a
canonical type should have.

In C++, all template specialization types for ther same template
are the same if the full list of template arguments is the same,
an argument being defaulted or not doesn't matter.

Moreover, this information is already available in the sugared
template specialization type, in the sense that, taking the as-written
list and matching it up to the template parameters, any parameters which
are left without a corresponding template argument must have been defaulted.

This patch besides removing that bit, changes the current DebugInfo users to derive
that information from the as-written argument list. And it goes a little beyond
that by wiring up the actual sugared TemplateArguments, so the Debug Info
produced is also richer.

This patch is a performance improvement, as the TemplateArgument is one of the
hottest data structures for C++ compilation:

The small regression on `-O0 -g` test is explained by the increased amount of
debug info generated.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications