[all-commits] [llvm/llvm-project] ee55ef: [TableGen][DecoderEmitter] Repurpose Filter class ...

Sergei Barannikov via All-commits all-commits at lists.llvm.org
Fri Aug 22 23:01:45 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee55efc711f401f8626a02a1ff8639fec27084b2
      https://github.com/llvm/llvm-project/commit/ee55efc711f401f8626a02a1ff8639fec27084b2
  Author: Sergei Barannikov <barannikov88 at gmail.com>
  Date:   2025-08-23 (Sat, 23 Aug 2025)

  Changed paths:
    M llvm/utils/TableGen/DecoderEmitter.cpp

  Log Message:
  -----------
  [TableGen][DecoderEmitter] Repurpose Filter class (#155065)

There was a lot of confusion about the responsibilities of Filter and
FilterChooser. They created instances of each other and called each
other's methods. Some of the methods had similar names and did similar
things.

This change moves most of the Filter members to FilterChooser and turns
Filter into a supplementary class with short lifetime. FilterChooser
constructs an array of (candidate) Filters, chooses the best performing
one, and applies it to the given set of encodings, creating inferior
FilterChoosers as necessary. The Filter array is then destroyed. All
responsibility for generating the decoder table now lies with
FilterChooser.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list