[all-commits] [llvm/llvm-project] d44754: ARM: Remove redundant or buggy config of __aeabi_d...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d44754c344885c249f381ace54ab1947e2d0f9fc
      https://github.com/llvm/llvm-project/commit/d44754c344885c249f381ace54ab1947e2d0f9fc
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-08-06 (Wed, 06 Aug 2025)

  Changed paths:
    M llvm/lib/Target/ARM/ARMISelLowering.cpp

  Log Message:
  -----------
  ARM: Remove redundant or buggy config of __aeabi_d2h (#152126)

This was set if `TT.isTargetAEABI()`. This was previously set above
if `TM.isAAPCS_ABI() && (TT.isTargetAEABI() || TT.isTargetGNUAEABI() ||
                         TT.isTargetMuslAEABI() || TT.isAndroid())`.

So this could differ based on a manually specified -target-abi flag due
to the `isAAPCS_ABI` part of the original condition. I'm guessing
these should be consistent, so either this second group of
setLibcallImpl
calls should have been guarded by the `isAAPCS_ABI` check, or the first
condition should remove it.

There doesn't appear to be any meaningful test coverage using the
manually specified ABI option, so #152108 tries to remove it



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications