[all-commits] [llvm/llvm-project] 97dee3: [MLIR][Presburger] add iterVarKind for convenient ...

[Stanislav Mekhanoshin via All-commits]

  Branch: refs/heads/users/rampitec/08-05-_amdgpu_add_gfx1250_wmma_scale_16__f32_32x16x128_f4_instructions
  Home:   https://github.com/llvm/llvm-project
  Commit: 97dee3244535b4bc6cfb65a1dfa8f3ae93bd5752
      https://github.com/llvm/llvm-project/commit/97dee3244535b4bc6cfb65a1dfa8f3ae93bd5752
  Author: Jeremy Kun <jkun at google.com>
  Date:   2025-08-05 (Tue, 05 Aug 2025)

  Changed paths:
    M mlir/include/mlir/Analysis/Presburger/IntegerRelation.h
    M mlir/unittests/Analysis/Presburger/IntegerRelationTest.cpp

  Log Message:
  -----------
  [MLIR][Presburger] add iterVarKind for convenient iterating over variables (#152091)

I find myself doing this alot

```
for (unsigned varIndex = rel.getVarKindOffset(VarKind::Domain);
     varIndex < rel.getVarKindEnd(VarKind::Domain); ++varIndex) {
  ...
}
```

Adding this convenience method so I can instead do

```
for (unsigned varIndex : rel.iterVarKind(VarKind::Domain)) {
  ...
}
```

---------

Co-authored-by: Jeremy Kun <j2kun at users.noreply.github.com>


  Commit: da6424c9e307cd324f37745b525d3884b5077707
      https://github.com/llvm/llvm-project/commit/da6424c9e307cd324f37745b525d3884b5077707
  Author: Jann <jannh at google.com>
  Date:   2025-08-05 (Tue, 05 Aug 2025)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/test/CodeGen/AArch64/xray-custom-log.ll
    M llvm/test/CodeGen/X86/xray-custom-log.ll
    A llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs-indirect.ll
    M llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll

  Log Message:
  -----------
  [DebugInfo][DWARF] Don't emit bogus DW_AT_call_target for complex calls (#151378)

On X86-64, LLVM currently generates the same DWARF debug info for `call
rax` and `call [rax]`; in both cases, the generated DWARF claims that
the call goes to address RAX. This bug occurs because the X86 machine
instructions CALL64r and CALL64m both receive register operands, but
those register operands have different semantics.

To fix it, change DwarfDebug::constructCallSiteEntryDIEs() to validate
the callee operand's semantics (`OperandType`) and make sure it is not
semantically describing a memory location.

This fix will result in less DW_TAG_call_site and DW_AT_call_target
entries being generated.

There is an existing test in dwarf-callsite-related-attrs.ll that
asserts the broken behavior; remove the broken check, and instead add a
new test dwarf-callsite-related-attrs-indirect.ll that checks behavior
for indirect calls.

The existing test xray-custom-log.ll is validating something even more
broken: It checks the debug info generated by a PATCHABLE_EVENT_CALL.
`TII->getCalleeOperand()` assumes that the first argument of a call
instruction is always the destination, but the first argument of
PATCHABLE_EVENT_CALL is instead the event structure; and so we were
emitting debug info claiming the callee was stored in a register that
actually contains some kind of xray event descriptor, and the test
validates that this happens.
I am breaking and deleting this test.
I guess the intent there might have been to validate that we emit
debuginfo referencing the target of the direct call that LLVM emits
(which we don't do)? But I'm not sure.


  Commit: b86e38e7554daac4220a3aa43228f1041d297528
      https://github.com/llvm/llvm-project/commit/b86e38e7554daac4220a3aa43228f1041d297528
  Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
  Date:   2025-08-05 (Tue, 05 Aug 2025)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/test/CodeGen/AArch64/xray-custom-log.ll
    M llvm/test/CodeGen/X86/xray-custom-log.ll
    A llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs-indirect.ll
    M llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll
    M mlir/include/mlir/Analysis/Presburger/IntegerRelation.h
    M mlir/unittests/Analysis/Presburger/IntegerRelationTest.cpp

  Log Message:
  -----------
  Merge branch 'main' into users/rampitec/08-05-_amdgpu_add_gfx1250_wmma_scale_16__f32_32x16x128_f4_instructions


Compare: https://github.com/llvm/llvm-project/compare/98e9fb454c3a...b86e38e7554d

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications