[all-commits] [llvm/llvm-project] 57b084: MCSymbol: Remove isUnset

Fangrui Song via All-commits all-commits at lists.llvm.org
Sun Aug 3 21:31:34 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57b0843f68f5f349c73d1bf54e321a1a6d1800bf
      https://github.com/llvm/llvm-project/commit/57b0843f68f5f349c73d1bf54e321a1a6d1800bf
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-08-03 (Sun, 03 Aug 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCSymbol.h
    M llvm/lib/MC/MCParser/AsmParser.cpp

  Log Message:
  -----------
  MCSymbol: Remove isUnset

The isUnset state lacks significance and should be treated as equivalent
to an undefined symbol.

Equated and common symbols seem to have subtle semantic distinctions in
GAS, justifying the use of distinct `SymContents*` values.

TODO: Ensure common symbols have a fragment, so that `isDefined()`
returns true, rejecting `.comm c, 4, 4; .set c, 4`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list